Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1fa6dba

Browse filesBrowse files
bnoordhuisFishrock123
authored andcommitted
src: fix readability/nolint cpplint warnings
PR-URL: #7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent 43e8357 commit 1fa6dba
Copy full SHA for 1fa6dba

File tree

Expand file treeCollapse file tree

2 files changed

+4
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-5
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ template int SSLWrap<TLSWrap>::SelectALPNCallback(
175175
#endif // TLSEXT_TYPE_application_layer_protocol_negotiation
176176

177177
static void crypto_threadid_cb(CRYPTO_THREADID* tid) {
178-
static_assert(sizeof(uv_thread_t) <= sizeof(void*), // NOLINT(runtime/sizeof)
178+
static_assert(sizeof(uv_thread_t) <= sizeof(void*),
179179
"uv_thread_t does not fit in a pointer");
180180
CRYPTO_THREADID_set_pointer(tid, reinterpret_cast<void*>(uv_thread_self()));
181181
}
@@ -693,7 +693,7 @@ void SecureContext::AddCACert(const FunctionCallbackInfo<Value>& args) {
693693

694694
unsigned cert_count = 0;
695695
if (BIO* bio = LoadBIO(env, args[0])) {
696-
while (X509* x509 = // NOLINT(whitespace/if-one-line)
696+
while (X509* x509 =
697697
PEM_read_bio_X509(bio, nullptr, CryptoPemCallback, nullptr)) {
698698
X509_STORE_add_cert(sc->ca_store_, x509);
699699
SSL_CTX_add_client_CA(sc->ctx_, x509);
Collapse file

‎src/spawn_sync.cc‎

Copy file name to clipboardExpand all lines: src/spawn_sync.cc
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,7 @@ int SyncProcessRunner::CopyJsStringArray(Local<Value> js_value,
992992
data_size = 0;
993993
for (uint32_t i = 0; i < length; i++) {
994994
data_size += StringBytes::StorageSize(isolate, js_array->Get(i), UTF8) + 1;
995-
data_size = ROUND_UP(data_size, sizeof(void*)); // NOLINT(runtime/sizeof)
995+
data_size = ROUND_UP(data_size, sizeof(void*));
996996
}
997997

998998
buffer = new char[list_size + data_size];
@@ -1008,8 +1008,7 @@ int SyncProcessRunner::CopyJsStringArray(Local<Value> js_value,
10081008
js_array->Get(i),
10091009
UTF8);
10101010
buffer[data_offset++] = '\0';
1011-
data_offset = ROUND_UP(data_offset,
1012-
sizeof(void*)); // NOLINT(runtime/sizeof)
1011+
data_offset = ROUND_UP(data_offset, sizeof(void*));
10131012
}
10141013

10151014
list[length] = nullptr;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.