Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1ef2811

Browse filesBrowse files
sam-githubBridgeAR
authored andcommitted
test: only assert on first lines of TLS trace
The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, and it's enough to check that trace was enabled via CLI. PR-URL: #28043 Fixes: #27636 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 9dd4813 commit 1ef2811
Copy full SHA for 1ef2811

File tree

Expand file treeCollapse file tree

2 files changed

+0
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+0
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ prefix parallel
99
test-net-connect-options-port: PASS,FLAKY
1010
# https://github.com/nodejs/node/issues/26401
1111
test-worker-prof: PASS,FLAKY
12-
# https://github.com/nodejs/node/issues/27553
13-
test-tls-enable-trace-cli: PASS,FLAKY
1412

1513
[$system==win32]
1614
test-http2-pipe: PASS,FLAKY
Collapse file

‎test/parallel/test-tls-enable-trace-cli.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-enable-trace-cli.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ child.on('close', common.mustCall((code, signal) => {
3737
assert.strictEqual(stdout.trim(), '');
3838
assert(/Warning: Enabling --trace-tls can expose sensitive/.test(stderr));
3939
assert(/Sent Record/.test(stderr));
40-
assert(/Received Record/.test(stderr));
4140
}));
4241

4342
function test() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.