Commit 1e3aed0
test: fix flaky parallel/test-http2-client-upload
In parallel/test-http2-client-upload, the `client.destroy()`
call could terminate the connection before all data was sent
over the wire successfully.
Using `client.shutdown()` removes the flakiness.
Also, listen on `req.on('finish')` rather than the file stream’s
`end` event, since we’re not interested in when the source stream
finishes, but rather when the HTTP/2 stream finishes.
PR-URL: #17361
Refs: #17356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>1 parent 7ae7124 commit 1e3aed0Copy full SHA for 1e3aed0
File tree
Expand file treeCollapse file tree
1 file changed
+2
-2
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+2
-2
lines changedOpen diff view settings
Collapse file
test/parallel/test-http2-client-upload.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-client-upload.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
| 41 | + |
42 | 42 | |
43 | 43 | |
44 | 44 | |
| ||
47 | 47 | |
48 | 48 | |
49 | 49 | |
50 | | - |
| 50 | + |
51 | 51 | |
52 | 52 | |
53 | 53 | |
0 commit comments