Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1ce9416

Browse filesBrowse files
addaleaxtargos
authored andcommitted
test: fix flaky addons/callback-scope/test-resolve-async
Fixes: #22668 PR-URL: #22664 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 2b49b43 commit 1ce9416
Copy full SHA for 1ce9416

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎test/addons/callback-scope/test-resolve-async.js‎

Copy file name to clipboardExpand all lines: test/addons/callback-scope/test-resolve-async.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ const common = require('../../common');
44
const assert = require('assert');
55
const { testResolveAsync } = require(`./build/${common.buildType}/binding`);
66

7+
// Checks that resolving promises from C++ works.
8+
79
let called = false;
810
testResolveAsync().then(() => { called = true; });
911

10-
setTimeout(() => { assert(called); }, common.platformTimeout(50));
12+
process.on('beforeExit', () => { assert(called); });

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.