Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 1bedeeb

Browse filesBrowse files
Trottjasnell
Trott
authored and
jasnell
committed
benchmark: fix lint errors
PR-URL: #5517 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 66ea32d commit 1bedeeb
Copy full SHA for 1bedeeb
Expand file treeCollapse file tree

16 files changed

+60
-26
lines changed
Open diff view settings
Collapse file

‎benchmark/arrays/var-int.js‎

Copy file name to clipboardExpand all lines: benchmark/arrays/var-int.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
var common = require('../common.js');
33
var bench = common.createBenchmark(main, {
4-
type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),
4+
type: ['Array', 'Buffer', 'Int8Array', 'Uint8Array', 'Int16Array',
5+
'Uint16Array', 'Int32Array', 'Uint32Array', 'Float32Array',
6+
'Float64Array'],
57
n: [25]
68
});
79

Collapse file

‎benchmark/arrays/zero-float.js‎

Copy file name to clipboardExpand all lines: benchmark/arrays/zero-float.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
var common = require('../common.js');
33
var bench = common.createBenchmark(main, {
4-
type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),
4+
type: ['Array', 'Buffer', 'Int8Array', 'Uint8Array', 'Int16Array',
5+
'Uint16Array', 'Int32Array', 'Uint32Array', 'Float32Array',
6+
'Float64Array'],
57
n: [25]
68
});
79

Collapse file

‎benchmark/arrays/zero-int.js‎

Copy file name to clipboardExpand all lines: benchmark/arrays/zero-int.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
var common = require('../common.js');
33
var bench = common.createBenchmark(main, {
4-
type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),
4+
type: ['Array', 'Buffer', 'Int8Array', 'Uint8Array', 'Int16Array',
5+
'Uint16Array', 'Int32Array', 'Uint32Array', 'Float32Array',
6+
'Float64Array'],
57
n: [25]
68
});
79

Collapse file

‎benchmark/buffers/buffer-creation.js‎

Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-creation.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function main(conf) {
1414
var clazz = conf.type === 'fast' ? Buffer : SlowBuffer;
1515
bench.start();
1616
for (var i = 0; i < n * 1024; i++) {
17-
b = new clazz(len);
17+
new clazz(len);
1818
}
1919
bench.end(n);
2020
}
Collapse file

‎benchmark/buffers/buffer-indexof.js‎

Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-indexof.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22
var common = require('../common.js');
33
var fs = require('fs');
4+
const path = require('path');
45

56
var bench = common.createBenchmark(main, {
67
search: ['@', 'SQ', '10x', '--l', 'Alice', 'Gryphon', 'Panther',
@@ -15,7 +16,9 @@ var bench = common.createBenchmark(main, {
1516

1617
function main(conf) {
1718
var iter = (conf.iter) * 100000;
18-
var aliceBuffer = fs.readFileSync(__dirname + '/../fixtures/alice.html');
19+
var aliceBuffer = fs.readFileSync(
20+
path.resolve(__dirname, '../fixtures/alice.html')
21+
);
1922
var search = conf.search;
2023
var encoding = conf.encoding;
2124

Collapse file

‎benchmark/compare.js‎

Copy file name to clipboardExpand all lines: benchmark/compare.js
+20-5Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,15 @@ function run() {
7777

7878
var out = '';
7979
var child;
80-
if (Array.isArray(benchmarks) && benchmarks.length)
81-
child = spawn(node, ['benchmark/common.js'].concat(benchmarks), { env: env });
82-
else
80+
if (Array.isArray(benchmarks) && benchmarks.length) {
81+
child = spawn(
82+
node,
83+
['benchmark/common.js'].concat(benchmarks),
84+
{ env: env }
85+
);
86+
} else {
8387
child = spawn('make', [runBench], { env: env });
88+
}
8489
child.stdout.setEncoding('utf8');
8590
child.stdout.on('data', function(c) {
8691
out += c;
@@ -136,8 +141,18 @@ function compare() {
136141
if (show === 'green' && !g || show === 'red' && !r)
137142
return;
138143

139-
var r0 = util.format('%s%s: %d%s', g, nodes[0], n0.toPrecision(5), g ? reset : '');
140-
var r1 = util.format('%s%s: %d%s', r, nodes[1], n1.toPrecision(5), r ? reset : '');
144+
var r0 = util.format(
145+
'%s%s: %d%s',
146+
g,
147+
nodes[0],
148+
n0.toPrecision(5), g ? reset : ''
149+
);
150+
var r1 = util.format(
151+
'%s%s: %d%s',
152+
r,
153+
nodes[1],
154+
n1.toPrecision(5), r ? reset : ''
155+
);
141156
pct = c + pct + '%' + reset;
142157
var l = util.format('%s: %s %s', bench, r0, r1);
143158
maxLen = Math.max(l.length + pct.length, maxLen);
Collapse file

‎benchmark/domain/domain-fn-args.js‎

Copy file name to clipboardExpand all lines: benchmark/domain/domain-fn-args.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ function main(conf) {
2020
for (var i = 0; i < n; i++) {
2121
if (myArguments.length >= 2) {
2222
args = Array.prototype.slice.call(myArguments, 1);
23-
ret = fn.apply(this, args);
23+
fn.apply(this, args);
2424
} else {
25-
ret = fn.call(this);
25+
fn.call(this);
2626
}
2727
}
2828
bdomain.exit();
Collapse file

‎benchmark/fs/bench-readdir.js‎

Copy file name to clipboardExpand all lines: benchmark/fs/bench-readdir.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
const common = require('../common');
44
const fs = require('fs');
5+
const path = require('path');
56

67
const bench = common.createBenchmark(main, {
78
n: [1e4],
@@ -15,7 +16,7 @@ function main(conf) {
1516
(function r(cntr) {
1617
if (--cntr <= 0)
1718
return bench.end(n);
18-
fs.readdir(__dirname + '/../../lib/', function() {
19+
fs.readdir(path.resolve(__dirname, '../../lib/'), function() {
1920
r(cntr);
2021
});
2122
}(n));
Collapse file

‎benchmark/fs/bench-readdirSync.js‎

Copy file name to clipboardExpand all lines: benchmark/fs/bench-readdirSync.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
const common = require('../common');
44
const fs = require('fs');
5+
const path = require('path');
56

67
const bench = common.createBenchmark(main, {
78
n: [1e4],
@@ -13,7 +14,7 @@ function main(conf) {
1314

1415
bench.start();
1516
for (var i = 0; i < n; i++) {
16-
fs.readdirSync(__dirname + '/../../lib/');
17+
fs.readdirSync(path.resolve(__dirname, '../../lib/'));
1718
}
1819
bench.end(n);
1920
}
Collapse file

‎benchmark/http_simple_auto.js‎

Copy file name to clipboardExpand all lines: benchmark/http_simple_auto.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,10 @@ server.listen(port, function() {
111111
});
112112

113113
function dump_mm_stats() {
114-
if (typeof gc != 'function') return;
114+
if (typeof global.gc != 'function') return;
115115

116116
var before = process.memoryUsage();
117-
for (var i = 0; i < 10; ++i) gc();
117+
for (var i = 0; i < 10; ++i) global.gc();
118118
var after = process.memoryUsage();
119119
setTimeout(print_stats, 250); // give GC time to settle
120120

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.