Commit 194eeb8
test: drop Isolate::GetCurrent() from addon tests
v8::Isolate::GetCurrent() is not exactly deprecated at this point but
its use is strongly discouraged. Update the addon tests so they no
longer use it.
PR-URL: #2427
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent 46cdb2f commit 194eeb8Copy full SHA for 194eeb8
File tree
Expand file treeCollapse file tree
4 files changed
+9
-9
lines changedOpen diff view settings
Filter options
- test/addons
- async-hello-world
- at-exit
- hello-world-function-export
- hello-world
Expand file treeCollapse file tree
4 files changed
+9
-9
lines changedOpen diff view settings
Collapse file
test/addons/async-hello-world/binding.cc
Copy file name to clipboardExpand all lines: test/addons/async-hello-world/binding.cc+5-3Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7 | 7 | |
8 | 8 | |
9 | 9 | |
| 10 | + |
10 | 11 | |
11 | 12 | |
12 | 13 | |
| ||
17 | 18 | |
18 | 19 | |
19 | 20 | |
20 | | - |
21 | | - |
22 | 21 | |
| 22 | + |
| 23 | + |
23 | 24 | |
24 | 25 | |
25 | 26 | |
| ||
42 | 43 | |
43 | 44 | |
44 | 45 | |
45 | | - |
| 46 | + |
46 | 47 | |
47 | 48 | |
48 | 49 | |
49 | 50 | |
50 | 51 | |
51 | 52 | |
52 | 53 | |
| 54 | + |
53 | 55 | |
54 | 56 | |
55 | 57 | |
|
Collapse file
test/addons/at-exit/binding.cc
Copy file name to clipboardExpand all lines: test/addons/at-exit/binding.cc+2-4Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
16 | 16 | |
17 | 17 | |
18 | 18 | |
19 | | - |
20 | | - |
| 19 | + |
21 | 20 | |
22 | | - |
23 | 21 | |
24 | 22 | |
25 | 23 | |
| ||
37 | 35 | |
38 | 36 | |
39 | 37 | |
40 | | - |
| 38 | + |
41 | 39 | |
42 | 40 | |
43 | 41 | |
|
Collapse file
test/addons/hello-world-function-export/binding.cc
Copy file name to clipboardExpand all lines: test/addons/hello-world-function-export/binding.cc+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2 | 2 | |
3 | 3 | |
4 | 4 | |
5 | | - |
| 5 | + |
6 | 6 | |
7 | 7 | |
8 | 8 | |
|
Collapse file
test/addons/hello-world/binding.cc
Copy file name to clipboardExpand all lines: test/addons/hello-world/binding.cc+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2 | 2 | |
3 | 3 | |
4 | 4 | |
5 | | - |
| 5 | + |
6 | 6 | |
7 | 7 | |
8 | 8 | |
|
0 commit comments