Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1918b4e

Browse filesBrowse files
Trotttargos
authored andcommitted
test: correct header length subtraction
In test-http-max-http-headers, a comment asks why we are subtracting 32 from the length of the invalid-length-by-1 headers instead of just 1. Subtracting 1 seems to be correct and works. PR-URL: #30712 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1222be8 commit 1918b4e
Copy full SHA for 1918b4e

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-http-max-http-headers.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-http-max-http-headers.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ function fillHeaders(headers, currentSize, valid = false) {
3737

3838
// Generate valid headers
3939
if (valid) {
40-
// TODO(mcollina): understand why -32 is needed instead of -1
41-
headers = headers.slice(0, -32);
40+
headers = headers.slice(0, -1);
4241
}
4342
return headers + '\r\n\r\n';
4443
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.