Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1916acb

Browse filesBrowse files
codebytereaddaleax
authored andcommitted
src: fix signal handler crash on close
PR-URL: #30582 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
1 parent 19d192d commit 1916acb
Copy full SHA for 1916acb

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎src/signal_wrap.cc‎

Copy file name to clipboardExpand all lines: src/signal_wrap.cc
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ class SignalWrap : public HandleWrap {
9191
}
9292

9393
void Close(v8::Local<v8::Value> close_callback) override {
94-
if (active_) DecreaseSignalHandlerCount(handle_.signum);
94+
if (active_) {
95+
DecreaseSignalHandlerCount(handle_.signum);
96+
active_ = false;
97+
}
9598
HandleWrap::Close(close_callback);
9699
}
97100

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.