Commit 190ddce
stream: only use legacy close listeners if not willEmitClose
Some streams that willEmitClose unecessarily fallback to legacy
events.
PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 651e7d2 commit 190ddceCopy full SHA for 190ddce
File tree
Expand file treeCollapse file tree
2 files changed
+27
-2
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
2 files changed
+27
-2
lines changedOpen diff view settings
Collapse file
lib/internal/streams/end-of-stream.js
Copy file name to clipboardExpand all lines: lib/internal/streams/end-of-stream.js+4-2Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
129 | 129 | |
130 | 130 | |
131 | 131 | |
132 | | - |
| 132 | + |
| 133 | + |
| 134 | + |
133 | 135 | |
134 | 136 | |
135 | 137 | |
| ||
138 | 140 | |
139 | 141 | |
140 | 142 | |
141 | | - |
| 143 | + |
142 | 144 | |
143 | 145 | |
144 | 146 | |
|
Collapse file
test/parallel/test-stream-finished.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-finished.js+23Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
492 | 492 | |
493 | 493 | |
494 | 494 | |
| 495 | + |
| 496 | + |
| 497 | + |
| 498 | + |
| 499 | + |
| 500 | + |
| 501 | + |
| 502 | + |
| 503 | + |
| 504 | + |
| 505 | + |
| 506 | + |
| 507 | + |
| 508 | + |
| 509 | + |
| 510 | + |
| 511 | + |
| 512 | + |
| 513 | + |
| 514 | + |
| 515 | + |
| 516 | + |
| 517 | + |
0 commit comments