Commit 1906077
v8: fix stack overflow in recursive method
HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock()
used to self-recurse before this commit, causing stack overflows on
systems with small stack sizes. Make it non-recursive by storing
intermediate results in a heap-allocated list.
Fixes: #11991
PR-URL: #12460
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>1 parent 5fb7a0b commit 1906077Copy full SHA for 1906077
File tree
Expand file treeCollapse file tree
1 file changed
+17
-11
lines changedOpen diff view settings
Filter options
- deps/v8/src/crankshaft
Expand file treeCollapse file tree
1 file changed
+17
-11
lines changedOpen diff view settings
Collapse file
deps/v8/src/crankshaft/hydrogen-gvn.cc
Copy file name to clipboardExpand all lines: deps/v8/src/crankshaft/hydrogen-gvn.cc+17-11Lines changed: 17 additions & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
5 | 5 | |
6 | 6 | |
7 | 7 | |
| 8 | + |
| 9 | + |
8 | 10 | |
9 | 11 | |
10 | 12 | |
| ||
651 | 653 | |
652 | 654 | |
653 | 655 | |
654 | | - |
655 | | - |
656 | | - |
657 | | - |
658 | | - |
659 | | - |
660 | | - |
661 | | - |
662 | | - |
| 656 | + |
| 657 | + |
| 658 | + |
| 659 | + |
| 660 | + |
| 661 | + |
| 662 | + |
| 663 | + |
| 664 | + |
| 665 | + |
| 666 | + |
| 667 | + |
| 668 | + |
663 | 669 | |
664 | | - |
665 | | - |
666 | 670 | |
| 671 | + |
| 672 | + |
667 | 673 | |
668 | 674 | |
669 | 675 | |
|
0 commit comments