Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 18ea8cf

Browse filesBrowse files
seantcoyoteMylesBorins
authored andcommitted
test: fix assertion arguments order
There's no issue for this PR, it's a task at the Node+JS Code-n-Learn. PR-URL: #23584 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent c9ba20a commit 18ea8cf
Copy full SHA for 18ea8cf

File tree

Expand file treeCollapse file tree

1 file changed

+32
-33
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+32
-33
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-querystring.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-querystring.js
+32-33Lines changed: 32 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,8 @@ const qsUnescapeTestCases = [
177177
' !"#$%&\'()*+,-./01234567']
178178
];
179179

180-
assert.strictEqual('918854443121279438895193',
181-
qs.parse('id=918854443121279438895193').id);
182-
180+
assert.strictEqual(qs.parse('id=918854443121279438895193').id,
181+
'918854443121279438895193');
183182

184183
function check(actual, expected, input) {
185184
assert(!(actual instanceof Object));
@@ -221,7 +220,7 @@ qsWeirdObjects.forEach((testCase) => {
221220
});
222221

223222
qsNoMungeTestCases.forEach((testCase) => {
224-
assert.deepStrictEqual(testCase[0], qs.stringify(testCase[1], '&', '='));
223+
assert.deepStrictEqual(qs.stringify(testCase[1], '&', '='), testCase[0]);
225224
});
226225

227226
// test the nested qs-in-qs case
@@ -259,15 +258,15 @@ qsNoMungeTestCases.forEach((testCase) => {
259258

260259
// basic
261260
qsTestCases.forEach((testCase) => {
262-
assert.strictEqual(testCase[1], qs.stringify(testCase[2]));
261+
assert.strictEqual(qs.stringify(testCase[2]), testCase[1]);
263262
});
264263

265264
qsColonTestCases.forEach((testCase) => {
266-
assert.strictEqual(testCase[1], qs.stringify(testCase[2], ';', ':'));
265+
assert.strictEqual(qs.stringify(testCase[2], ';', ':'), testCase[1]);
267266
});
268267

269268
qsWeirdObjects.forEach((testCase) => {
270-
assert.strictEqual(testCase[1], qs.stringify(testCase[0]));
269+
assert.strictEqual(qs.stringify(testCase[0]), testCase[1]);
271270
});
272271

273272
// invalid surrogate pair throws URIError
@@ -281,12 +280,12 @@ common.expectsError(
281280
);
282281

283282
// coerce numbers to string
284-
assert.strictEqual('foo=0', qs.stringify({ foo: 0 }));
285-
assert.strictEqual('foo=0', qs.stringify({ foo: -0 }));
286-
assert.strictEqual('foo=3', qs.stringify({ foo: 3 }));
287-
assert.strictEqual('foo=-72.42', qs.stringify({ foo: -72.42 }));
288-
assert.strictEqual('foo=', qs.stringify({ foo: NaN }));
289-
assert.strictEqual('foo=', qs.stringify({ foo: Infinity }));
283+
assert.strictEqual(qs.stringify({ foo: 0 }), 'foo=0');
284+
assert.strictEqual(qs.stringify({ foo: -0 }), 'foo=0');
285+
assert.strictEqual(qs.stringify({ foo: 3 }), 'foo=3');
286+
assert.strictEqual(qs.stringify({ foo: -72.42 }), 'foo=-72.42');
287+
assert.strictEqual(qs.stringify({ foo: NaN }), 'foo=');
288+
assert.strictEqual(qs.stringify({ foo: Infinity }), 'foo=');
290289

291290
// nested
292291
{
@@ -360,26 +359,26 @@ assert.strictEqual(
360359
const b = qs.unescapeBuffer('%d3%f2Ug%1f6v%24%5e%98%cb' +
361360
'%0d%ac%a2%2f%9d%eb%d8%a2%e6');
362361
// <Buffer d3 f2 55 67 1f 36 76 24 5e 98 cb 0d ac a2 2f 9d eb d8 a2 e6>
363-
assert.strictEqual(0xd3, b[0]);
364-
assert.strictEqual(0xf2, b[1]);
365-
assert.strictEqual(0x55, b[2]);
366-
assert.strictEqual(0x67, b[3]);
367-
assert.strictEqual(0x1f, b[4]);
368-
assert.strictEqual(0x36, b[5]);
369-
assert.strictEqual(0x76, b[6]);
370-
assert.strictEqual(0x24, b[7]);
371-
assert.strictEqual(0x5e, b[8]);
372-
assert.strictEqual(0x98, b[9]);
373-
assert.strictEqual(0xcb, b[10]);
374-
assert.strictEqual(0x0d, b[11]);
375-
assert.strictEqual(0xac, b[12]);
376-
assert.strictEqual(0xa2, b[13]);
377-
assert.strictEqual(0x2f, b[14]);
378-
assert.strictEqual(0x9d, b[15]);
379-
assert.strictEqual(0xeb, b[16]);
380-
assert.strictEqual(0xd8, b[17]);
381-
assert.strictEqual(0xa2, b[18]);
382-
assert.strictEqual(0xe6, b[19]);
362+
assert.strictEqual(b[0], 0xd3);
363+
assert.strictEqual(b[1], 0xf2);
364+
assert.strictEqual(b[2], 0x55);
365+
assert.strictEqual(b[3], 0x67);
366+
assert.strictEqual(b[4], 0x1f);
367+
assert.strictEqual(b[5], 0x36);
368+
assert.strictEqual(b[6], 0x76);
369+
assert.strictEqual(b[7], 0x24);
370+
assert.strictEqual(b[8], 0x5e);
371+
assert.strictEqual(b[9], 0x98);
372+
assert.strictEqual(b[10], 0xcb);
373+
assert.strictEqual(b[11], 0x0d);
374+
assert.strictEqual(b[12], 0xac);
375+
assert.strictEqual(b[13], 0xa2);
376+
assert.strictEqual(b[14], 0x2f);
377+
assert.strictEqual(b[15], 0x9d);
378+
assert.strictEqual(b[16], 0xeb);
379+
assert.strictEqual(b[17], 0xd8);
380+
assert.strictEqual(b[18], 0xa2);
381+
assert.strictEqual(b[19], 0xe6);
383382
}
384383

385384
assert.strictEqual(qs.unescapeBuffer('a+b', true).toString(), 'a b');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.