Commit 18c4933
test: remove unnecessary timer
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.
PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent cb36b67 commit 18c4933Copy full SHA for 18c4933
File tree
Expand file treeCollapse file tree
1 file changed
+1
-8
lines changedOpen diff view settings
Filter options
- test/addons-napi/test_callback_scope
Expand file treeCollapse file tree
1 file changed
+1
-8
lines changedOpen diff view settings
Collapse file
test/addons-napi/test_callback_scope/test-resolve-async.js
Copy file name to clipboard+1-8Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
5 | 4 | |
6 | 5 | |
7 | | - |
8 | | - |
9 | | - |
10 | | - |
11 | | - |
12 | | - |
13 | | - |
| 6 | + |
0 commit comments