Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 18c4933

Browse filesBrowse files
cjihrigMylesBorins
authored andcommitted
test: remove unnecessary timer
The timer in NAPI's test_callback_scope/test-resolve-async.js can be removed. If the test fails, it will timeout on its own. The extra timer increases the chances of the test being flaky. PR-URL: #18719 Fixes: #18702 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent cb36b67 commit 18c4933
Copy full SHA for 18c4933

File tree

Expand file treeCollapse file tree

1 file changed

+1
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-8
lines changed
Open diff view settings
Collapse file
+1-8Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
'use strict';
22

33
const common = require('../../common');
4-
const assert = require('assert');
54
const { testResolveAsync } = require(`./build/${common.buildType}/binding`);
65

7-
let called = false;
8-
testResolveAsync().then(common.mustCall(() => {
9-
called = true;
10-
}));
11-
12-
setTimeout(common.mustCall(() => { assert(called); }),
13-
common.platformTimeout(20));
6+
testResolveAsync().then(common.mustCall());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.