Commit 1894d6c
repl: fix tab completion for object properties with special char
The old RegExp will pass property names like `"hello world!"`
when filtering the results of tab complete. This change is to
fix it.
Fixes: #21201
PR-URL: #21556
Fixes: #21201
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>1 parent 24bc6ab commit 1894d6cCopy full SHA for 1894d6c
File tree
Expand file treeCollapse file tree
2 files changed
+30
-4
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+30
-4
lines changedOpen diff view settings
Collapse file
+24-4Lines changed: 24 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
47 | 47 | |
48 | 48 | |
49 | 49 | |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
50 | 54 | |
51 | 55 | |
52 | 56 | |
| ||
900 | 904 | |
901 | 905 | |
902 | 906 | |
903 | | - |
904 | | - |
905 | | - |
| 907 | + |
| 908 | + |
| 909 | + |
| 910 | + |
| 911 | + |
| 912 | + |
| 913 | + |
| 914 | + |
| 915 | + |
| 916 | + |
| 917 | + |
| 918 | + |
| 919 | + |
| 920 | + |
| 921 | + |
| 922 | + |
| 923 | + |
| 924 | + |
| 925 | + |
906 | 926 | |
907 | 927 | |
908 | 928 | |
| ||
932 | 952 | |
933 | 953 | |
934 | 954 | |
935 | | - |
| 955 | + |
936 | 956 | |
937 | 957 | |
938 | 958 | |
|
Collapse file
test/parallel/test-repl-tab-complete.js
Copy file name to clipboardExpand all lines: test/parallel/test-repl-tab-complete.js+6Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
369 | 369 | |
370 | 370 | |
371 | 371 | |
| 372 | + |
| 373 | + |
| 374 | + |
| 375 | + |
| 376 | + |
| 377 | + |
372 | 378 | |
373 | 379 | |
374 | 380 | |
|
0 commit comments