Commit 1850879
committed
js_stream: prevent abort if isalive doesn't exist
Attempting to check IsAlive() on a JSStream before the isAlive()
callback can be set in JS causes a CHECK to fail in MakeCallback.
Instead return false if the callback hasn't been set.
PR-URL: #3282
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>1 parent 26a7ec6 commit 1850879Copy full SHA for 1850879
File tree
Expand file treeCollapse file tree
2 files changed
+12
-1
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
2 files changed
+12
-1
lines changedOpen diff view settings
Collapse file
+4-1Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
44 | 44 | |
45 | 45 | |
46 | 46 | |
47 | | - |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
48 | 51 | |
49 | 52 | |
50 | 53 | |
|
Collapse file
test/parallel/test-js-stream-call-properties.js
Copy file name to clipboard+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
0 commit comments