Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 182c73b

Browse filesBrowse files
addaleaxaddaleax
committed
http2: switch to new runtime-controlled debugging system
Remove `--debug-http2` as a compile-time feature and make all debug statements available using `NODE_DEBUG_NATIVE=http2` at runtime. This probably makes the debugging-enabled case a bit slower due to additional string concatenations, but switching to a runtime-checking system makes debugging more flexible and can be applied more easily to other parts of the source code as well. PR-URL: #20987 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 45eeea4 commit 182c73b
Copy full SHA for 182c73b

File tree

Expand file treeCollapse file tree

6 files changed

+115
-154
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+115
-154
lines changed
Open diff view settings
Collapse file

‎configure‎

Copy file name to clipboardExpand all lines: configure
-10Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -443,11 +443,6 @@ parser.add_option('--debug-lib',
443443
dest='node_debug_lib',
444444
help='build lib with DCHECK macros')
445445

446-
http2_optgroup.add_option('--debug-http2',
447-
action='store_true',
448-
dest='debug_http2',
449-
help='build with http2 debug statements on (default is false)')
450-
451446
http2_optgroup.add_option('--debug-nghttp2',
452447
action='store_true',
453448
dest='debug_nghttp2',
@@ -970,11 +965,6 @@ def configure_node(o):
970965

971966
o['variables']['node_debug_lib'] = b(options.node_debug_lib)
972967

973-
if options.debug_http2:
974-
o['variables']['debug_http2'] = 1
975-
else:
976-
o['variables']['debug_http2'] = 'false'
977-
978968
if options.debug_nghttp2:
979969
o['variables']['debug_nghttp2'] = 1
980970
else:
Collapse file

‎node.gypi‎

Copy file name to clipboardExpand all lines: node.gypi
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,6 @@
9090
'NODE_RELEASE_URLBASE="<(node_release_urlbase)"',
9191
]
9292
}],
93-
[
94-
'debug_http2==1', {
95-
'defines': [ 'NODE_DEBUG_HTTP2=1' ]
96-
}],
9793
[ 'v8_enable_i18n_support==1', {
9894
'defines': [ 'NODE_HAVE_I18N_SUPPORT=1' ],
9995
'dependencies': [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.