Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 17c2ddd

Browse filesBrowse files
jagannathBhatMylesBorins
authored andcommitted
doc: improve COLLABORATOR_GUIDE
PR-URL: #23977 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent a9dcf6f commit 17c2ddd
Copy full SHA for 17c2ddd

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ This should be done where a pull request:
497497

498498
Assign the `tsc-review` label or @-mention the
499499
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
500-
Do not use the GitHub UI on the right hand side to assign to
500+
Do not use the GitHub UI on the right-hand side to assign to
501501
`@nodejs/tsc` or request a review from `@nodejs/tsc`.
502502

503503
The TSC should serve as the final arbiter where required.
@@ -528,7 +528,7 @@ The TSC should serve as the final arbiter where required.
528528
you are unsure exactly how to format the commit messages, use the commit log
529529
as a reference. See [this commit][commit-example] as an example.
530530

531-
For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors).
531+
For PRs from first-time contributors, be [welcoming](#welcoming-first-time-contributors).
532532
Also, verify that their git settings are to their liking.
533533

534534
All commits should be self-contained, meaning every commit should pass all

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.