Commit 1666600
test: improve code in test-console-instance
* use common.mustCall to validate functions executions
* use common.fail to check test fail
* improve error validations
* remove unnecessary assertions
* use arrow functions
PR-URL: #10813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent b496374 commit 1666600Copy full SHA for 1666600
File tree
Expand file treeCollapse file tree
1 file changed
+18
-30
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+18
-30
lines changedOpen diff view settings
Collapse file
test/parallel/test-console-instance.js
Copy file name to clipboard+18-30Lines changed: 18 additions & 30 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | | - |
| 2 | + |
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | | - |
7 | 6 | |
8 | 7 | |
9 | 8 | |
10 | 9 | |
11 | 10 | |
12 | 11 | |
13 | | - |
14 | | - |
15 | | - |
| 12 | + |
16 | 13 | |
17 | 14 | |
18 | 15 | |
19 | 16 | |
20 | 17 | |
21 | 18 | |
22 | | - |
| 19 | + |
23 | 20 | |
24 | | - |
| 21 | + |
25 | 22 | |
26 | 23 | |
27 | | - |
28 | | - |
| 24 | + |
| 25 | + |
29 | 26 | |
30 | 27 | |
31 | | - |
| 28 | + |
32 | 29 | |
33 | | - |
| 30 | + |
34 | 31 | |
35 | 32 | |
36 | 33 | |
37 | | - |
| 34 | + |
38 | 35 | |
39 | | - |
40 | | - |
| 36 | + |
41 | 37 | |
42 | | - |
43 | 38 | |
44 | | - |
45 | | - |
46 | | - |
47 | 39 | |
48 | | - |
49 | 40 | |
50 | | - |
| 41 | + |
51 | 42 | |
52 | | - |
53 | | - |
| 43 | + |
54 | 44 | |
55 | | - |
56 | 45 | |
57 | | - |
58 | 46 | |
59 | 47 | |
60 | | - |
61 | | - |
| 48 | + |
| 49 | + |
62 | 50 | |
63 | | - |
64 | | - |
| 51 | + |
| 52 | + |
| 53 | + |
65 | 54 | |
66 | | - |
67 | 55 | |
68 | 56 | |
69 | | - |
| 57 | + |
70 | 58 | |
71 | 59 | |
0 commit comments