Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 15b6bcf

Browse filesBrowse files
gibfahnMylesBorins
authored andcommitted
test: make debugging of inspector-port-zero easier
If the process was killed, then the exit code will be null, in which case knowing the signal is really helpful. PR-URL: #16685 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 9914bca commit 15b6bcf
Copy full SHA for 15b6bcf

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-inspector-port-zero.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-inspector-port-zero.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ function test(arg, port = '') {
3434
};
3535
proc.stdout.on('close', mustCall(() => onclose()));
3636
proc.stderr.on('close', mustCall(() => onclose()));
37-
proc.on('exit', mustCall((exitCode) => assert.strictEqual(exitCode, 0)));
37+
proc.on('exit', mustCall((exitCode, signal) => assert.strictEqual(
38+
exitCode,
39+
0,
40+
`exitCode: ${exitCode}, signal: ${signal}`)));
3841
}
3942
}
4043

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.