Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1549048

Browse filesBrowse files
committed
src: spin shutdown loop while immediates are pending
This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: #34662 Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent dabd04d commit 1549048
Copy full SHA for 1549048

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,10 @@ void Environment::RunCleanup() {
604604
"RunCleanup", this);
605605
CleanupHandles();
606606

607-
while (!cleanup_hooks_.empty()) {
607+
while (!cleanup_hooks_.empty() ||
608+
native_immediates_.size() > 0 ||
609+
native_immediates_threadsafe_.size() > 0 ||
610+
native_immediates_interrupts_.size() > 0) {
608611
// Copy into a vector, since we can't sort an unordered_set in-place.
609612
std::vector<CleanupHookCallback> callbacks(
610613
cleanup_hooks_.begin(), cleanup_hooks_.end());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.