Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 14e07c9

Browse filesBrowse files
radelmannMylesBorins
authored andcommitted
test: refactor test-stdin-from-file
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0e51cbb commit 14e07c9
Copy full SHA for 14e07c9

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-stdin-from-file.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stdin-from-file.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ fs.writeFileSync(tmpFile, string);
3333
childProcess.exec(cmd, common.mustCall(function(err, stdout, stderr) {
3434
fs.unlinkSync(tmpFile);
3535

36-
if (err) throw err;
37-
console.log(stdout);
36+
assert.ifError(err);
3837
assert.strictEqual(stdout, 'hello world\r\n' + string);
3938
assert.strictEqual('', stderr);
4039
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.