Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 14bce1e

Browse filesBrowse files
committed
report: do not use uv_default_loop() as fallback
Not seeing an associated `Environment` is a rare condition anyway, but using `uv_default_loop()` as a fallback is not thread-safe. PR-URL: #25652 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent b113332 commit 14bce1e
Copy full SHA for 14bce1e

File tree

Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Collapse file

‎src/node_report.cc‎

Copy file name to clipboardExpand all lines: src/node_report.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,6 @@ static void WriteNodeReport(Isolate* isolate,
307307
writer.json_arraystart("libuv");
308308
if (env != nullptr)
309309
uv_walk(env->event_loop(), WalkHandle, static_cast<void*>(&writer));
310-
else
311-
uv_walk(uv_default_loop(), WalkHandle, static_cast<void*>(&writer));
312310

313311
writer.json_arrayend();
314312

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.