Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 144233b

Browse filesBrowse files
islandryumarco-ippolito
authored andcommitted
process: fix wrong asyncContext under unhandled-rejections=strict
Fixes: #60034 PR-URL: #60103 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent b1da374 commit 144233b
Copy full SHA for 144233b

File tree

Expand file treeCollapse file tree

2 files changed

+30
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+30
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/process/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/promises.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ function strictUnhandledRejectionsMode(promise, promiseInfo, promiseAsyncId) {
340340
reason : new UnhandledPromiseRejection(reason);
341341
// This destroys the async stack, don't clear it after
342342
triggerUncaughtException(err, true /* fromPromise */);
343-
if (promiseAsyncId === undefined) {
343+
if (promiseAsyncId !== undefined) {
344344
pushAsyncContext(
345345
promise[kAsyncIdSymbol],
346346
promise[kTriggerAsyncIdSymbol],
Collapse file
+29Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
// Flags: --unhandled-rejections=strict
2+
'use strict';
3+
4+
const common = require('../common');
5+
const fs = require('fs');
6+
const assert = require('assert');
7+
8+
process.on('unhandledRejection', common.mustNotCall);
9+
10+
process.on('uncaughtException', common.mustCall((err) => {
11+
assert.ok(err.message.includes('foo'));
12+
}));
13+
14+
15+
async function readFile() {
16+
return fs.promises.readFile(__filename);
17+
}
18+
19+
async function crash() {
20+
throw new Error('foo');
21+
}
22+
23+
24+
async function main() {
25+
crash();
26+
readFile();
27+
}
28+
29+
main();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.