Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 13c6cec

Browse filesBrowse files
addaleaxMylesBorins
addaleax
authored and
MylesBorins
committed
test: fail for missing output files
Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 544920f commit 13c6cec
Copy full SHA for 13c6cec

File tree

Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Collapse file

‎test/message/testcfg.py‎

Copy file name to clipboardExpand all lines: test/message/testcfg.py
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,7 @@ def ListTests(self, current_path, path, arch, mode):
127127
file_path = file_prefix + ".js"
128128
output_path = file_prefix + ".out"
129129
if not exists(output_path):
130-
print "Could not find %s" % output_path
131-
continue
130+
raise Exception("Could not find %s" % output_path)
132131
result.append(MessageTestCase(test, file_path, output_path,
133132
arch, mode, self.context, self))
134133
return result
Collapse file

‎test/pseudo-tty/testcfg.py‎

Copy file name to clipboardExpand all lines: test/pseudo-tty/testcfg.py
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,7 @@ def ListTests(self, current_path, path, arch, mode):
142142
file_path = file_prefix + ".js"
143143
output_path = file_prefix + ".out"
144144
if not exists(output_path):
145-
print "Could not find %s" % output_path
146-
continue
145+
raise Exception("Could not find %s" % output_path)
147146
result.append(TTYTestCase(test, file_path, output_path,
148147
arch, mode, self.context, self))
149148
return result

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.