Commit 138d004
buffer: faster case for create Buffer from new Buffer(0)
When create Buffer from a Buffer will copy data
from old to new even though length is zero.
This patch can improve edge case 4x faster.
following is benchmark results.
new: buffers/buffer_zero.js n=1024: 2463.53891
old: buffers/buffer_zero.js n=1024: 618.70801
PR-URL: #4326
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3ff2373 commit 138d004Copy full SHA for 138d004
File tree
Expand file treeCollapse file tree
2 files changed
+22
-0
lines changedOpen diff view settings
Filter options
- benchmark/buffers
- lib
Expand file treeCollapse file tree
2 files changed
+22
-0
lines changedOpen diff view settings
Collapse file
benchmark/buffers/buffer_zero.js
Copy file name to clipboard+18Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
123 | 123 | |
124 | 124 | |
125 | 125 | |
| 126 | + |
| 127 | + |
| 128 | + |
| 129 | + |
126 | 130 | |
127 | 131 | |
128 | 132 | |
|
0 commit comments