Commit 12d76b8
tls: reset secureConnecting on client socket
secureConnecting is never set to false on client TLS sockets.
So if Http2Session constructor (in lib/internal/http2/core.js) is
called after secureConnect is emitted, then it will wrongly wait
for a secureConnect event.
This fix sets secureConnecting to false when a client TLS socket
has connected.
Backport-PR-URL: #34859
PR-URL: #33209
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>1 parent 70768ce commit 12d76b8Copy full SHA for 12d76b8
File tree
Expand file treeCollapse file tree
2 files changed
+35
-1
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+35
-1
lines changedOpen diff view settings
Collapse file
+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1523 | 1523 | |
1524 | 1524 | |
1525 | 1525 | |
| 1526 | + |
1526 | 1527 | |
1527 | 1528 | |
1528 | 1529 | |
1529 | 1530 | |
| 1531 | + |
1530 | 1532 | |
1531 | 1533 | |
1532 | 1534 | |
|
Collapse file
test/parallel/test-http2-connect.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-connect.js+33-1Lines changed: 33 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
9 | 9 | |
10 | 10 | |
11 | 11 | |
| 12 | + |
12 | 13 | |
13 | | - |
| 14 | + |
14 | 15 | |
| 16 | + |
15 | 17 | |
16 | 18 | |
17 | 19 | |
| ||
70 | 72 | |
71 | 73 | |
72 | 74 | |
| 75 | + |
| 76 | + |
| 77 | + |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
| 83 | + |
| 84 | + |
| 85 | + |
| 86 | + |
| 87 | + |
| 88 | + |
| 89 | + |
| 90 | + |
| 91 | + |
| 92 | + |
| 93 | + |
| 94 | + |
| 95 | + |
| 96 | + |
| 97 | + |
| 98 | + |
| 99 | + |
| 100 | + |
| 101 | + |
| 102 | + |
| 103 | + |
| 104 | + |
73 | 105 | |
74 | 106 | |
75 | 107 | |
|
0 commit comments