Commit 12657ac
build: add .gitattributes for npm and other shims
This issue has been described in -
#43860
On Windows system, git clone or git checkout on the repo turns LF line
endings to CRLF in the worktree.
This can happen due to many reasons like -
- git config --system core.autocrlf (set to true)
- git config --global core.autocrlf (set to true)
- git config --local core.autocrlf (set to true)
- git clone --config core.autocrlf=true ...
Adding gitattributes for the shims will not convert them to CRLF line
endings.
Also, there is a note[1] in test/README.md which says -
For the tests to run on Windows, be sure to clone Node.js source code
with the `autocrlf` git config flag set to true.
Reason for using build subsystem -
These shims are just copied in stage_package label of vcbuild.bat
Fixes: #43860
[1]: 3654cd4
PR-URL: #43879
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent aac97c2 commit 12657acCopy full SHA for 12657ac
File tree
Expand file treeCollapse file tree
1 file changed
+3
-0
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
1 file changed
+3
-0
lines changedOpen diff view settings
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
| 3 | + |
| 4 | + |
| 5 | + |
3 | 6 | |
0 commit comments