Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 11af089

Browse filesBrowse files
committed
src: update NODE_MODULE_VERSION to 120
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 17c55d1 commit 11af089
Copy full SHA for 11af089

File tree

Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎doc/abi_version_registry.json‎

Copy file name to clipboardExpand all lines: doc/abi_version_registry.json
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 120,"runtime": "node", "variant": "v8_11.8", "versions": "21.0.0-pre" },
34
{ "modules": 119,"runtime": "electron", "variant": "electron", "versions": "28" },
45
{ "modules": 118,"runtime": "electron", "variant": "electron", "versions": "27" },
56
{ "modules": 117,"runtime": "electron", "variant": "electron", "versions": "26" },
Collapse file

‎src/node_version.h‎

Copy file name to clipboardExpand all lines: src/node_version.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
#if defined(NODE_EMBEDDER_MODULE_VERSION)
9696
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
9797
#else
98-
#define NODE_MODULE_VERSION 115
98+
#define NODE_MODULE_VERSION 120
9999
#endif
100100

101101
// The NAPI_VERSION supported by the runtime. This is the inclusive range of

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.