Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1160d61

Browse filesBrowse files
cjihrigMylesBorins
authored andcommitted
assert: support symbols as assertion messages
Currently, assertion messages are implicitly converted to strings, which causes symbols to throw. This commit adds an explicit string conversion. PR-URL: #20693 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0d28b4b commit 1160d61
Copy full SHA for 1160d61

File tree

Expand file treeCollapse file tree

2 files changed

+11
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+11
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/assert.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ class AssertionError extends Error {
196196
} = options;
197197

198198
if (message != null) {
199-
super(message);
199+
super(String(message));
200200
} else {
201201
if (process.stdout.isTTY) {
202202
// Reset on each call to make sure we handle dynamically set environment
Collapse file

‎test/parallel/test-assert.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert.js
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -640,6 +640,16 @@ common.expectsError(
640640
}
641641
);
642642

643+
common.expectsError(
644+
() => assert(false, Symbol('foo')),
645+
{
646+
code: 'ERR_ASSERTION',
647+
type: assert.AssertionError,
648+
generatedMessage: false,
649+
message: 'Symbol(foo)'
650+
}
651+
);
652+
643653
{
644654
// Test caching.
645655
const fs = process.binding('fs');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.