Commit 0eb3ed5
test: reduce brittleness of tab complete test
test-repl-tab-complete includes tests that ensure that certain keys do
not appear in tab completions or that completion does not crash the
repl. It performed these tests by comparing completion output to a
hardcoded list of expected keys. This list is made incorrect by any api
changes that occur when new versions of V8 are introduced.
With this change, we assert that the specific keys to be avoided are
not present in the output instead.
PR-URL: #5772
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent a38d6ad commit 0eb3ed5Copy full SHA for 0eb3ed5
File tree
Expand file treeCollapse file tree
1 file changed
+6
-77
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+6
-77
lines changedOpen diff view settings
Collapse file
test/parallel/test-repl-tab-complete.js
Copy file name to clipboardExpand all lines: test/parallel/test-repl-tab-complete.js+6-77Lines changed: 6 additions & 77 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
226 | 226 | |
227 | 227 | |
228 | 228 | |
229 | | - |
230 | | - |
231 | | - |
232 | | - |
233 | | - |
234 | | - |
235 | | - |
236 | | - |
237 | | - |
238 | | - |
239 | | - |
240 | | - |
241 | | - |
242 | | - |
243 | | - |
244 | 229 | |
245 | 230 | |
246 | | - |
247 | 231 | |
248 | 232 | |
249 | 233 | |
250 | | - |
251 | | - |
252 | | - |
253 | | - |
254 | | - |
255 | | - |
256 | | - |
257 | | - |
258 | | - |
259 | | - |
260 | | - |
261 | | - |
262 | | - |
263 | | - |
264 | | - |
265 | | - |
266 | | - |
267 | | - |
268 | | - |
269 | | - |
270 | | - |
271 | | - |
272 | | - |
273 | | - |
274 | | - |
275 | | - |
276 | | - |
277 | | - |
278 | | - |
279 | | - |
280 | | - |
281 | | - |
282 | | - |
283 | | - |
284 | | - |
285 | | - |
286 | | - |
287 | | - |
288 | | - |
289 | | - |
290 | | - |
291 | | - |
292 | | - |
293 | 234 | |
294 | 235 | |
295 | 236 | |
296 | 237 | |
297 | | - |
| 238 | + |
| 239 | + |
| 240 | + |
298 | 241 | |
299 | 242 | |
300 | 243 | |
301 | | - |
302 | | - |
303 | | - |
304 | | - |
305 | | - |
306 | | - |
307 | | - |
308 | | - |
309 | | - |
310 | | - |
311 | | - |
312 | | - |
313 | | - |
314 | | - |
315 | | - |
316 | | - |
317 | 244 | |
318 | 245 | |
319 | 246 | |
320 | 247 | |
321 | | - |
| 248 | + |
| 249 | + |
| 250 | + |
322 | 251 | |
0 commit comments