Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0ea74f3

Browse filesBrowse files
codebytereRafaelGSS
authored andcommitted
test,crypto: make crypto tests work with BoringSSL
PR-URL: #55491 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent c874d03 commit 0ea74f3
Copy full SHA for 0ea74f3

File tree

Expand file treeCollapse file tree

3 files changed

+5
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-10
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-crypto-dh-errors.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-crypto-dh-errors.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ for (const g of [-1, 1]) {
4343
const ex = {
4444
code: 'ERR_OSSL_DH_BAD_GENERATOR',
4545
name: 'Error',
46-
message: /bad generator/,
46+
message: /(?:bad[_ ]generator)/i,
4747
};
4848
assert.throws(() => crypto.createDiffieHellman('abcdef', g), ex);
4949
assert.throws(() => crypto.createDiffieHellman('abcdef', 'hex', g), ex);
@@ -55,7 +55,7 @@ for (const g of [Buffer.from([]),
5555
const ex = {
5656
code: 'ERR_OSSL_DH_BAD_GENERATOR',
5757
name: 'Error',
58-
message: /bad generator/,
58+
message: /(?:bad[_ ]generator)/i,
5959
};
6060
assert.throws(() => crypto.createDiffieHellman('abcdef', g), ex);
6161
assert.throws(() => crypto.createDiffieHellman('abcdef', 'hex', g), ex);
Collapse file

‎test/parallel/test-crypto-private-decrypt-gh32240.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-crypto-private-decrypt-gh32240.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const pkeyEncrypted =
2424
pair.privateKey.export({
2525
type: 'pkcs1',
2626
format: 'pem',
27-
cipher: 'aes128',
27+
cipher: 'aes-128-cbc',
2828
passphrase: 'secret',
2929
});
3030

Collapse file

‎test/parallel/test-tls-getcertificate-x509.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-getcertificate-x509.js
+2-7Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ const server = tls.createServer(options, function(cleartext) {
2020
server.once('secureConnection', common.mustCall(function(socket) {
2121
const cert = socket.getX509Certificate();
2222
assert(cert instanceof X509Certificate);
23-
assert.strictEqual(
24-
cert.serialNumber,
25-
'5B75D77EDC7FB5B7FA9F1424DA4C64FB815DCBDE');
23+
assert.match(cert.serialNumber, /5B75D77EDC7FB5B7FA9F1424DA4C64FB815DCBDE/i);
2624
}));
2725

2826
server.listen(0, common.mustCall(function() {
@@ -33,10 +31,7 @@ server.listen(0, common.mustCall(function() {
3331
const peerCert = socket.getPeerX509Certificate();
3432
assert(peerCert.issuerCertificate instanceof X509Certificate);
3533
assert.strictEqual(peerCert.issuerCertificate.issuerCertificate, undefined);
36-
assert.strictEqual(
37-
peerCert.issuerCertificate.serialNumber,
38-
'147D36C1C2F74206DE9FAB5F2226D78ADB00A425'
39-
);
34+
assert.match(peerCert.issuerCertificate.serialNumber, /147D36C1C2F74206DE9FAB5F2226D78ADB00A425/i);
4035
server.close();
4136
}));
4237
socket.end('Hello');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.