Commit 0dec568
fs: remove broken code in promises/write
That code expects the last argument to be a callback.
When it's not a callback, it shifts arguments, defaulting
encoding to 'utf-8', which is clearly broken.
Old signature: (fd, string[, position[, encoding]], callback)
New signature: (fd, string[, position[, encoding]])
PR-URL: #20407
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jamie Davis <davisjam@vt.edu>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>1 parent b172f6b commit 0dec568Copy full SHA for 0dec568
File tree
Expand file treeCollapse file tree
1 file changed
+0
-9
lines changedOpen diff view settings
Filter options
- lib/internal/fs
Expand file treeCollapse file tree
1 file changed
+0
-9
lines changedOpen diff view settings
Collapse file
lib/internal/fs/promises.js
Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js-9Lines changed: 0 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
242 | 242 | |
243 | 243 | |
244 | 244 | |
245 | | - |
246 | | - |
247 | | - |
248 | | - |
249 | | - |
250 | | - |
251 | | - |
252 | | - |
253 | | - |
254 | 245 | |
255 | 246 | |
256 | 247 | |
|
0 commit comments