Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0d5a508

Browse filesBrowse files
TrottMyles Borins
authored andcommitted
test: extend timeout in Debug mode
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-GH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-GH-5504.js. PR-URL: #4431 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
1 parent 6e4598d commit 0d5a508
Copy full SHA for 0d5a508

File tree

Expand file treeCollapse file tree

2 files changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎test/common.js‎

Copy file name to clipboardExpand all lines: test/common.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,9 @@ exports.spawnPwd = function(options) {
255255
};
256256

257257
exports.platformTimeout = function(ms) {
258+
if (process.config.target_defaults.default_configuration === 'Debug')
259+
ms = 2 * ms;
260+
258261
if (process.arch !== 'arm')
259262
return ms;
260263

Collapse file

‎test/sequential/test-net-GH-5504.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-net-GH-5504.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22
var common = require('../common');
3-
var assert = require('assert');
43

54
// this test only fails with CentOS 6.3 using kernel version 2.6.32
65
// On other linuxes and darwin, the `read` call gets an ECONNRESET in

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.