Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 0d3e3dd

Browse filesBrowse files
VoltrexKeyvaMoLow
VoltrexKeyva
authored and
MoLow
committed
tools: update PR label config
- Update paths to the new ones. - Remove paths that no longer exist. - Capitalize comments and quote labels mentioned within. - Fix syntax error in regex. - Add missing JavaScript subsystems. PR-URL: #47593 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent ec5c919 commit 0d3e3dd
Copy full SHA for 0d3e3dd

File tree

Expand file treeCollapse file tree

1 file changed

+37
-41
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+37
-41
lines changed
Open diff view settings
Collapse file

‎.github/label-pr-config.yml‎

Copy file name to clipboardExpand all lines: .github/label-pr-config.yml
+37-41Lines changed: 37 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
## earlier entries override later entries
33
subSystemLabels:
44
# src subsystems
5-
/^src\/async-wrap/: c++, async_wrap
5+
/^src\/async_wrap/: c++, async_wrap
66
/^src\/(?:base64|node_buffer|string_)/: c++, buffer
77
/^src\/cares/: c++, cares
88
/^src\/(?:process_wrap|spawn_)/: c++, child_process
99
/^src\/(?:node_)?crypto/: c++, crypto
10-
/^src\/(?:debug-|node_debug)/: c++, debugger
10+
/^src\/debug_/: c++, debugger
1111
/^src\/udp_/: c++, dgram
1212
/^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs
1313
/^src\/node_http_parser/: c++, http_parser
@@ -16,14 +16,13 @@ subSystemLabels:
1616
/^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net
1717
/^src\/node_os/: c++, os
1818
/^src\/(?:node_main|signal_)/: c++, process
19-
/^src\/timer_/: c++, timers
20-
/^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls
19+
/^src\/timer[_s]/: c++, timers
20+
/^src\/node_root_certs/: c++, tls
2121
/^src\/tty_/: c++, tty
2222
/^src\/node_url/: c++, whatwg-url
2323
/^src\/node_util/: c++, util
2424
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
2525
/^src\/node_contextify/: c++, vm
26-
/^src\/.*win32.*/: c++, windows
2726
/^src\/node_zlib/: c++, zlib
2827
/^src\/tracing/: c++, tracing
2928
/^src\/(?:node_api|js_native_api)/: c++, node-api
@@ -35,48 +34,44 @@ subSystemLabels:
3534
/^src\/node_bob*/: c++, quic, dont-land-on-v14.x
3635
/^src\/node_sea/: single-executable
3736

38-
# don't label python files as c++
39-
/^src\/.+\.py$/: python, needs-ci
40-
41-
# properly label changes to v8 inspector integration-related files
37+
# Properly label changes to V8 inspector integration-related files
4238
/^src\/inspector_/: c++, inspector, needs-ci
4339

44-
# don't want to label it a c++ update when we're "only" bumping the Node.js version
40+
# Don't want to label it a C++ update when we're "only" bumping the Node.js version
4541
/^src\/(?!node_version\.h)/: c++
4642
# BUILDING.md should be marked as 'build' in addition to 'doc'
4743
/^BUILDING\.md$/: build, doc
48-
# meta is a very specific label for things that are policy and or meta-info related
49-
/^([A-Z]+$|CODE_OF_CONDUCT|ROADMAP|WORKING_GROUPS|GOVERNANCE|CHANGELOG|\.mail|\.git.+)/: meta
50-
# things that edit top-level .md files are always a doc change
44+
# 'meta' is a very specific label for things that are policy and or meta-info related
45+
/^(?:[A-Z]+$|CODE_OF_CONDUCT|GOVERNANCE|CHANGELOG|\.mail|\.git.+)/: meta
46+
# Things that edit top-level .md files are always a doc change
5147
/^\w+\.md$/: doc
52-
# different variants of *Makefile and build files
53-
/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci
54-
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
48+
# Different variants of Makefile and build files
49+
/^(?:tools\/)?(?:Makefile|BSDmakefile|create_android_makefiles)$/: build, needs-ci
50+
/^tools\/(?:install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
5551
/^vcbuild\.bat$/: build, windows, needs-ci
56-
/^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
57-
# more specific tools
52+
/^(?:android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
53+
# More specific tools
5854
/^tools\/gyp/: tools, build, gyp, needs-ci, dont-land-on-v14.x
5955
/^tools\/doc\//: tools, doc
6056
/^tools\/icu\//: tools, i18n-api, icu, needs-ci
61-
/^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
62-
/^tools\/(?:(?:mac)?osx-)/: tools, macos
57+
/^tools\/osx-/: tools, macos
6358
/^tools\/test-npm/: tools, test, npm
6459
/^tools\/test/: tools, test
6560
/^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls
6661
/^tools\/msvs\//: tools, windows, install, needs-ci
6762
/^tools\/[^/]+\.bat$/: tools, windows, needs-ci
6863
/^tools\/make-v8/: tools, v8 engine, needs-ci
6964
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
70-
/^tools\/(code_cache|snapshot)/: needs-ci
65+
/^tools\/snapshot/: needs-ci
7166
/^tools\/build-addons.mjs/: needs-ci
72-
# all other tool changes should be marked as such
67+
# All other tool changes should be marked as such
7368
/^tools\//: tools
74-
/^\.eslint|\.remark|\.editorconfig/: tools
69+
/^\.eslint|\.editorconfig/: tools
7570
/^typings\//: typings
7671

7772
## Dependencies
7873
# libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
79-
# end up as libuv changes labeled with "uv" (which is a non-existing label)
74+
# end up as libuv changes labeled with 'uv' (which is a non-existing label)
8075
/^deps\/uv\//: libuv
8176
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
8277
/^deps\/v8\//: v8 engine
@@ -85,18 +80,17 @@ subSystemLabels:
8580
/^deps\/nghttp2\/nghttp2\.gyp/: build, http2
8681
/^deps\/nghttp2\//: http2
8782
/^deps\/ngtcp2\//: quic, dont-land-on-v14.x
88-
/^deps\/nghttp3\//: quic, dont-land-on-v14.x
8983
/^deps\/([^/]+)/: dependencies, $1
9084

9185
## JS subsystems
9286
# Oddities first
93-
/^lib\/(punycode|\w+\/freelist|sys\.js)/: ''
87+
/^lib\/(?:punycode|\w+\/freelist|sys\.js)/: ''
9488
/^lib\/constants\.js$/: lib / src
95-
/^lib\/_(debug_agent|debugger)\.js$/: debugger
96-
/^lib(\/\w+)?\/(_)?link(ed)?list/: timers
97-
/^lib\/\w+\/bootstrap_node/: lib / src
98-
/^lib\/\w+\/v8_prof_/: tools
99-
/^lib\/\w+\/socket_list/: net
89+
/^lib\/internal/debugger$/: debugger
90+
/^lib\/internal\/linkedlist\.js$/: timers
91+
/^lib\/internal\/bootstrap/: lib / src
92+
/^lib\/internal\/v8_prof_/: tools
93+
/^lib\/internal\/socket(?:_list|address)\.js$/: net
10094
/^lib\/\w+\/streams$/: stream
10195
/^lib\/.*http2/: http2
10296
/^lib\/worker_threads.js$/: worker
@@ -112,22 +106,21 @@ subSystemLabels:
112106
/^lib(?:\/internal)?\/(\w+)(?:\/|$)/: $1 # Subfolders
113107

114108
exlusiveLabels:
115-
# more specific tests
109+
# More specific tests
116110
/^test\/addons\//: test, addons
117-
/^test\/debugger\//: test, debugger
111+
/^test\/debugger/: test, debugger
118112
/^test\/doctool\//: test, doc, tools
119-
/^test\/timers\//: test, timers
113+
/^test\/timers/: test, timers
120114
/^test\/pseudo-tty\//: test, tty
121-
/^test\/inspector\//: test, inspector
115+
/^test\/inspector/: test, inspector
122116
/^test\/cctest\/test_inspector/: test, inspector
123-
/^test\/cctest\/test_url/: test, whatwg-url
124117
/^test\/node-api\//: test, node-api
125118
/^test\/js-native-api\//: test, node-api
126119
/^test\/async-hooks\//: test, async_hooks
127120
/^test\/report\//: test, report
128121
/^test\/fixtures\/es-module/: test, esm
129122
/^test\/es-module\//: test, esm
130-
/^test\/fixtures\/wpt\/streams//: test, web streams
123+
/^test\/fixtures\/wpt\/streams\//: test, web streams
131124

132125
/^test\//: test
133126

@@ -138,11 +131,9 @@ exlusiveLabels:
138131
# node-api is treated separately since it is not a JS core module but is still
139132
# considered a subsystem of sorts
140133
/^doc\/api\/n-api.md$/: doc, node-api
141-
# quic
142-
/^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x
143134
# Add worker label to PRs that affect doc/api/worker_threads.md
144135
/^doc\/api\/worker_threads.md$/: doc, worker
145-
# test runner documentation
136+
# test_runner documentation
146137
/^doc\/api\/test.md$/: doc, test_runner, dont-land-on-v14.x
147138
# Automatically tag JS subsystem-specific API doc changes
148139
/^doc\/api\/(\w+)\.md$/: doc, $1
@@ -154,7 +145,7 @@ exlusiveLabels:
154145

155146
# More specific benchmarks
156147
/^benchmark\/buffers\//: benchmark, buffer
157-
/^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
148+
/^benchmark\/es\//: benchmark, v8 engine
158149
/^benchmark\/_http/: benchmark, http
159150
/^benchmark\/(?:misc|fixtures)\//: benchmark
160151
/^benchmark\/streams\//: benchmark, stream
@@ -173,6 +164,7 @@ allJsSubSystems:
173164
- crypto
174165
- debugger
175166
- dgram
167+
- diagnostics_channel
176168
- dns
177169
- domain
178170
- events
@@ -181,11 +173,14 @@ allJsSubSystems:
181173
- http
182174
- https
183175
- http2
176+
- inspector
184177
- module
185178
- net
186179
- os
187180
- path
181+
- perf_hooks
188182
- process
183+
- punycode
189184
- querystring
190185
- quic
191186
- readline
@@ -195,6 +190,7 @@ allJsSubSystems:
195190
- string_decoder
196191
- timers
197192
- tls
193+
- trace_events
198194
- tty
199195
- typings
200196
- url

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.