Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0d00747

Browse filesBrowse files
MoLowruyadorno
authored andcommitted
test_runner: empty pending tests queue post running
PR-URL: #44059 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 1d6029a commit 0d00747
Copy full SHA for 0d00747

File tree

Expand file treeCollapse file tree

3 files changed

+3
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-2
lines changed
Open diff view settings
Collapse file

‎lib/internal/test_runner/test.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/test.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,7 @@ class Test extends AsyncResource {
523523

524524
// The test has run, so recursively cancel any outstanding subtests and
525525
// mark this test as failed if any subtests failed.
526+
this.pendingSubtests = [];
526527
for (let i = 0; i < this.subtests.length; i++) {
527528
const subtest = this.subtests[i];
528529

Collapse file

‎test/message/test_runner_unresolved_promise.js‎

Copy file name to clipboardExpand all lines: test/message/test_runner_unresolved_promise.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ const test = require('node:test');
55

66
test('pass');
77
test('never resolving promise', () => new Promise(() => {}));
8-
test('fail');
8+
test('fail', () => console.log('this should not appear'));
Collapse file

‎test/message/test_runner_unresolved_promise.out‎

Copy file name to clipboardExpand all lines: test/message/test_runner_unresolved_promise.out
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ not ok 2 - never resolving promise
1717
# Subtest: fail
1818
not ok 3 - fail
1919
---
20-
duration_ms: *
20+
duration_ms: 0
2121
failureType: 'cancelledByParent'
2222
error: 'test did not finish before its parent and was cancelled'
2323
code: 'ERR_TEST_FAILURE'

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.