Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0b376cb

Browse filesBrowse files
TrottMyles Borins
authored andcommitted
test: fix pummel test failures
A handful of tests in `test/pummel` were failing due to undefined variables. The tests in pummel are not run in CI or otherwise exercised regularly so these failures can go unnoticed for a long time. PR-URL: #6012 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 840c094 commit 0b376cb
Copy full SHA for 0b376cb

File tree

Expand file treeCollapse file tree

3 files changed

+9
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+9
-9
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-crypto-dh.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-crypto-dh.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

55
try {
66
var crypto = require('crypto');
Collapse file

‎test/pummel/test-dtrace-jsstack.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-dtrace-jsstack.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if (os.type() != 'SunOS') {
1414
var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ];
1515

1616
var stalloogle = function(str) {
17-
expected = str;
17+
global.expected = str;
1818
os.loadavg();
1919
};
2020

Collapse file

‎test/pummel/test-net-throttle.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-net-throttle.js
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var net = require('net');
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const net = require('net');
55

6-
var N = 1024 * 1024;
7-
var part_N = N / 3;
6+
const N = 1024 * 1024;
7+
const part_N = N / 3;
88
var chars_recved = 0;
99
var npauses = 0;
1010

1111
console.log('build big string');
12-
body = 'C'.repeat(N);
12+
const body = 'C'.repeat(N);
1313

1414
console.log('start server on port ' + common.PORT);
1515

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.