Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0aae502

Browse filesBrowse files
joaocgreistargos
authored andcommitted
build,win: propagate error codes in vcbuild
Don't exit vcbuild with error code 0 when cctest fails. PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 6a53152 commit 0aae502
Copy full SHA for 0aae502

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ set cctest=
6868
set openssl_no_asm=
6969
set doc=
7070
set extra_msbuild_args=
71+
set exit_code=0
7172

7273
:next-arg
7374
if "%1"=="" goto args-done
@@ -633,9 +634,11 @@ if defined no_cctest echo Skipping cctest because no-cctest was specified && got
633634
if not exist "%config%\cctest.exe" echo cctest.exe not found. Run "vcbuild test" or "vcbuild cctest" to build it. && goto run-test-py
634635
echo running 'cctest %cctest_args%'
635636
"%config%\cctest" %cctest_args%
637+
if %errorlevel% neq 0 set exit_code=%errorlevel%
636638
:run-test-py
637639
echo running 'python tools\test.py %test_args%'
638640
python tools\test.py %test_args%
641+
if %errorlevel% neq 0 set exit_code=%errorlevel%
639642
goto test-v8
640643

641644
:test-v8
@@ -715,7 +718,7 @@ echo vcbuild.bat no-cctest : skip building cctest.exe
715718
goto exit
716719

717720
:exit
718-
goto :EOF
721+
exit /b %exit_code%
719722

720723

721724
rem ***************

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.