Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0a952b8

Browse filesBrowse files
Han5991aduh95
authored andcommitted
test: ensure removeListener event fires for once() listeners
Adds test coverage for the removeListener event being emitted when a once() listener is automatically removed after execution. This verifies that streams and other EventEmitters correctly emit removeListener events when once() wrappers clean up. PR-URL: #60137 Fixes: #59977 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent a782598 commit 0a952b8
Copy full SHA for 0a952b8

2 files changed

+19-2Lines changed: 19 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/events.js‎

Copy file name to clipboardExpand all lines: lib/events.js
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -687,9 +687,10 @@ EventEmitter.prototype.removeListener =
687687
this._events = { __proto__: null };
688688
} else {
689689
delete events[type];
690-
if (events.removeListener)
691-
this.emit('removeListener', type, list.listener || listener);
692690
}
691+
692+
if (events.removeListener !== undefined)
693+
this.emit('removeListener', type, list.listener || listener);
693694
} else if (typeof list !== 'function') {
694695
let position = -1;
695696

Collapse file

‎test/parallel/test-event-emitter-remove-listeners.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-remove-listeners.js
+16Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,3 +168,19 @@ function listener2() {}
168168
ee.removeListener('foo', listener1);
169169
assert.strictEqual(ee._events.foo, listener2);
170170
}
171+
172+
{
173+
const { Writable } = require('stream');
174+
const stream = new Writable({
175+
write(chunk, encoding, callback) {
176+
callback();
177+
}
178+
});
179+
180+
stream.on('removeListener', common.mustCall((eventName, listener) => {
181+
assert.strictEqual(eventName, 'finish');
182+
}));
183+
184+
stream.once('finish', common.mustCall());
185+
stream.end();
186+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.