Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 0a5ff4c

Browse filesBrowse files
refacktargos
refack
authored and
targos
committed
deps: V8: template explicit instantiation for GCC-8
Fails to link for missing: void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...) Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent b411114 commit 0a5ff4c
Copy full SHA for 0a5ff4c

File tree

Expand file treeCollapse file tree

3 files changed

+11
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+11
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.9',
41+
'v8_embedder_string': '-node.10',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/src/elements.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/elements.cc
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@
6262
namespace v8 {
6363
namespace internal {
6464

65+
// Explicit instantiation declarations.
66+
extern template void JSObject::ApplyAttributesToDictionary(
67+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
68+
const PropertyAttributes attributes);
69+
6570

6671
namespace {
6772

Collapse file

‎deps/v8/src/objects/js-objects.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/js-objects.cc
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5836,5 +5836,10 @@ Handle<String> JSMessageObject::GetSourceLine() const {
58365836
return isolate->factory()->NewSubString(src, info.line_start, info.line_end);
58375837
}
58385838

5839+
// Explicit instantiation definitions.
5840+
template void JSObject::ApplyAttributesToDictionary(
5841+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
5842+
const PropertyAttributes attributes);
5843+
58395844
} // namespace internal
58405845
} // namespace v8

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.