Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0a0577c

Browse filesBrowse files
rvaggFishrock123
authored andcommitted
build: fix bad cherry-pick for vcbuild.bat build-release
PR-URL: #2625 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
1 parent 23579a5 commit 0a0577c
Copy full SHA for 0a0577c

File tree

Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ set noperfctr_msi_arg=
3636
set i18n_arg=
3737
set download_arg=
3838
set release_urls_arg=
39+
set build_release=
3940

4041
:next-arg
41-
set build_release=
4242
if "%1"=="" goto args-done
4343
if /i "%1"=="debug" set config=Debug&goto arg-ok
4444
if /i "%1"=="release" set config=Release&goto arg-ok
@@ -78,17 +78,17 @@ echo Warning: ignoring invalid command line option `%1`.
7878
:arg-ok
7979
shift
8080
goto next-arg
81+
82+
:args-done
83+
8184
if defined build_release (
82-
set nosnapshot=1
8385
set config=Release
8486
set msi=1
8587
set licensertf=1
8688
set download_arg="--download=all"
8789
set i18n_arg=small-icu
8890
)
8991

90-
91-
:args-done
9292
if "%config%"=="Debug" set debug_arg=--debug
9393
if defined nosnapshot set snapshot_arg=--without-snapshot
9494
if defined noetw set noetw_arg=--without-etw& set noetw_msi_arg=/p:NoETW=1
@@ -260,10 +260,10 @@ echo vcbuild.bat : builds release build
260260
echo vcbuild.bat debug : builds debug build
261261
echo vcbuild.bat release msi : builds release build and MSI installer package
262262
echo vcbuild.bat test : builds debug build and runs tests
263+
echo vcbuild.bat build-release : builds the release distribution as used by nodejs.org
263264
goto exit
264265

265266
:exit
266-
echo vcbuild.bat build-release : builds the release distribution as used by nodejs.org
267267
goto :EOF
268268

269269
rem ***************

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.