Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 09e4182

Browse filesBrowse files
Milad Farazmandtargos
authored andcommitted
deps: V8: cherry-pick d89f4ef1cd62
Original commit message: S390x: improve performance by skipping Debug Hook if not needed Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802 Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65644} Refs: v8/v8@d89f4ef PR-URL: #31354 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent 8252c06 commit 09e4182
Copy full SHA for 09e4182

File tree

Expand file treeCollapse file tree

2 files changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.29',
41+
'v8_embedder_string': '-node.30',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/src/codegen/s390/macro-assembler-s390.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/s390/macro-assembler-s390.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,8 +1336,8 @@ void MacroAssembler::CheckDebugHook(Register fun, Register new_target,
13361336
ExternalReference debug_hook_active =
13371337
ExternalReference::debug_hook_on_function_call_address(isolate());
13381338
Move(r6, debug_hook_active);
1339-
tm(MemOperand(r6), Operand::Zero());
1340-
bne(&skip_hook);
1339+
tm(MemOperand(r6), Operand(0xFF));
1340+
beq(&skip_hook);
13411341

13421342
{
13431343
// Load receiver to pass it later to DebugOnFunctionCall hook.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.