Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 09aec43

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
doc: remove vestigial onboarding section
The onboarding-extras doc includes a section with a single bullet point instructing the new Collaborator to write good pull request descriptions. This material is likely superfluous and is in the wrong document if it is not. (It more properly belongs in pull-requests.md as it is information that is not specific to new Collaborators.) I am not putting it in pullrequests.md because that document is already plenty long and detailed, and includes advice on writing good commit messages, which tend to become the pull request descriptions anyway. PR-URL: #21028 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent fd201e0 commit 09aec43
Copy full SHA for 09aec43

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Collapse file

‎doc/onboarding-extras.md‎

Copy file name to clipboardExpand all lines: doc/onboarding-extras.md
-4Lines changed: 0 additions & 4 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,3 @@ to update from nodejs/node:
9393
* `git checkout master`
9494
* `git remote update -p` OR `git fetch --all`
9595
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
96-
97-
## Best practices
98-
99-
* When making PRs, spend time writing a thorough description.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.