Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 09a1085

Browse filesBrowse files
sam-githubaddaleax
sam-github
authored and
addaleax
committed
src: remove unnecessary call to SSL_get_mode
SSL_set_mode() bit-ORs its argument into the current mode, its not necessary for to do it ourself (though it doesn't cause harm). See: - https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_mode.html - https://github.com/nodejs/node/blob/0ce615c4af/deps/openssl/openssl/ssl/ssl_lib.c#L2176-L2177 PR-URL: #25711 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 7ba6650 commit 09a1085
Copy full SHA for 09a1085

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎src/tls_wrap.cc‎

Copy file name to clipboardExpand all lines: src/tls_wrap.cc
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ void TLSWrap::InitSSL() {
110110
SSL_set_verify(ssl_.get(), SSL_VERIFY_NONE, crypto::VerifyCallback);
111111

112112
#ifdef SSL_MODE_RELEASE_BUFFERS
113-
long mode = SSL_get_mode(ssl_.get()); // NOLINT(runtime/int)
114-
SSL_set_mode(ssl_.get(), mode | SSL_MODE_RELEASE_BUFFERS);
113+
SSL_set_mode(ssl_.get(), SSL_MODE_RELEASE_BUFFERS);
115114
#endif // SSL_MODE_RELEASE_BUFFERS
116115

117116
SSL_set_app_data(ssl_.get(), this);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.