Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 0931f7e

Browse filesBrowse files
bnoordhuisBridgeAR
bnoordhuis
authored and
BridgeAR
committed
build: fix icu-i18n pkg-config version check
The pkg_config() helper can either return a tuple of None values (no pkg-config installed) and that was what the check was testing for, but it can also return a tuple of empty strings when the package isn't installed. PR-URL: #28118 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e2ad364 commit 0931f7e
Copy full SHA for 0931f7e

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ def write_config(data, name):
13481348
# ICU from pkg-config.
13491349
o['variables']['v8_enable_i18n_support'] = 1
13501350
pkgicu = pkg_config('icu-i18n')
1351-
if pkgicu[0] is None:
1351+
if not pkgicu[0]:
13521352
error('''Could not load pkg-config data for "icu-i18n".
13531353
See above errors or the README.md.''')
13541354
(libs, cflags, libpath, icuversion) = pkgicu

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.