Commit 092fb9f
authored
tls: use validateFunction for
If user uses invalid type for `options.checkServerIdentity`
in tls.connect(), it's not internal issue of Node.js. So
validateFunction() is more proper than assert().
Fixes: #49839
PR-URL: #49896
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>options.checkServerIdentity
1 parent e6e320e commit 092fb9fCopy full SHA for 092fb9f
File tree
Expand file treeCollapse file tree
2 files changed
+10
-1
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+10
-1
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1738 | 1738 | |
1739 | 1739 | |
1740 | 1740 | |
1741 | | - |
| 1741 | + |
1742 | 1742 | |
1743 | 1743 | |
1744 | 1744 | |
|
Collapse file
test/parallel/test-tls-basic-validations.js
Copy file name to clipboardExpand all lines: test/parallel/test-tls-basic-validations.js+9Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
135 | 135 | |
136 | 136 | |
137 | 137 | |
| 138 | + |
| 139 | + |
| 140 | + |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
| 145 | + |
| 146 | + |
0 commit comments