Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 091ba2c

Browse filesBrowse files
kunalspathakevanlucas
authored andcommitted
src: fix build break for !NODE_USE_V8_PLATFORM
`StartInspector` should return `bool` but there was signature mismatch if not building for v8 platform i.e. `!NODE_USE_V8_PLATFORM` PR-URL: #8114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent fbc5805 commit 091ba2c
Copy full SHA for 091ba2c

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,9 @@ static struct {
221221
void Initialize(int thread_pool_size) {}
222222
void PumpMessageLoop(Isolate* isolate) {}
223223
void Dispose() {}
224-
void StartInspector(Environment *env, int port, bool wait) {
224+
bool StartInspector(Environment *env, int port, bool wait) {
225225
env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
226+
return false; // make compiler happy
226227
}
227228
#endif // !NODE_USE_V8_PLATFORM
228229
} v8_platform;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.