Commit 09056fd
net: don't return the stream object from onStreamRead
CallJSOnreadMethod expects the return value to be undefined or
a new buffer, so make sure to return nothing, even when an error
causes us to destroy the stream.
Fixes: #34346
PR-URL: #34375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent e9a8f0c commit 09056fdCopy full SHA for 09056fd
File tree
Expand file treeCollapse file tree
1 file changed
+8
-3
lines changedOpen diff view settings
Filter options
- lib/internal
Expand file treeCollapse file tree
1 file changed
+8
-3
lines changedOpen diff view settings
Collapse file
lib/internal/stream_base_commons.js
Copy file name to clipboardExpand all lines: lib/internal/stream_base_commons.js+8-3Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
202 | 202 | |
203 | 203 | |
204 | 204 | |
205 | | - |
| 205 | + |
| 206 | + |
| 207 | + |
206 | 208 | |
207 | 209 | |
208 | 210 | |
| ||
219 | 221 | |
220 | 222 | |
221 | 223 | |
222 | | - |
223 | | - |
| 224 | + |
| 225 | + |
| 226 | + |
| 227 | + |
| 228 | + |
224 | 229 | |
225 | 230 | |
226 | 231 | |
|
0 commit comments