Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 08e924e

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
doc: require two-factor authentication
Collaborators have elevated privileges. The CTC now requires Collaborator accounts to have two-factor authentication. This changes wording in the onboarding documentation to make it clear that two-factor authentication is required and not merely recommended. PR-URL: #10529 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent b74bc51 commit 08e924e
Copy full SHA for 08e924e

File tree

Expand file treeCollapse file tree

1 file changed

+10
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+10
-5
lines changed
Open diff view settings
Collapse file

‎doc/onboarding.md‎

Copy file name to clipboardExpand all lines: doc/onboarding.md
+10-5Lines changed: 10 additions & 5 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,19 @@ onboarding session.
55

66
## One week before the onboarding session
77

8-
* Ask the new Collaborator if they are using two-factor authentication on their
9-
GitHub account. If they are not, suggest that they enable it as their account
10-
will have elevated privileges in many of the Node.js repositories.
8+
* Confirm that the new Collaborator is using two-factor authentication on their
9+
GitHub account. Unless two-factor authentication is enabled, do not give an
10+
account elevated privileges such as the ability to land code in the main
11+
repository or to start continuous integration (CI) jobs.
1112

1213
## Fifteen minutes before the onboarding session
1314

14-
* Prior to the onboarding session, add the new Collaborators to
15-
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
15+
* Prior to the onboarding session, add the new Collaborator to
16+
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
17+
Note that this is the step that gives the account elevated privileges, so
18+
do not perform this step (or any subsequent steps) unless two-factor
19+
authentication is enabled on the new Collaborator's GitHub account.
20+
1621

1722
## **thank you** for doing this
1823

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.