Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 08e5309

Browse filesBrowse files
Flarnaaduh95
authored andcommitted
Revert "build: avoid compiling with VS v17.12"
This reverts commit 542f252. PR-URL: #56151 Refs: nodejs/build#3963 Refs: #55930 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent 889094f commit 08e5309
Copy full SHA for 08e5309

File tree

Expand file treeCollapse file tree

1 file changed

+1
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-10
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+1-10Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,19 +292,10 @@ goto exit
292292
@rem Visual Studio v17.10 has a bug that causes the build to fail.
293293
@rem Check if the version is v17.10 and exit if it is.
294294
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
295-
if %errorlevel% neq 1 (
295+
if %errorlevel% neq 1 (
296296
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
297297
goto exit
298298
)
299-
@rem Same applies to v17.12 for MSVC.
300-
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
301-
if %errorlevel% neq 1 (
302-
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
303-
if not defined clang_cl (
304-
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
305-
goto exit
306-
)
307-
)
308299

309300
@rem check if the clang-cl build is requested
310301
if not defined clang_cl goto clang-skip

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.