Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 08da5c2

Browse filesBrowse files
mhdawsonrvagg
authored andcommitted
test: disable test-tick-processor - aix and be ppc
This test is already partially disabled for several platforms with the comment that the required info is not provided at the C++ level. I'm adding AIX as and PPC BE linux as they currently fall into the same category. We are working to see if we can change that in v8 but it will be non-trivial if is possible at all so I don't want to leave the CI with failing tests until that point. PR-URL: #3491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 70fca2a commit 08da5c2
Copy full SHA for 08da5c2

File tree

Expand file treeCollapse file tree

2 files changed

+10
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-3
lines changed
Open diff view settings
Collapse file

‎test/common.js‎

Copy file name to clipboardExpand all lines: test/common.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ exports.tmpDirName = 'tmp';
1414
exports.PORT = +process.env.NODE_COMMON_PORT || 12346;
1515
exports.isWindows = process.platform === 'win32';
1616
exports.isAix = process.platform === 'aix';
17+
exports.isLinuxPPCBE = (process.platform === 'linux') &&
18+
(process.arch === 'ppc64') &&
19+
(os.endianness() === 'BE');
20+
exports.isSunOS = process.platform === 'sunos';
21+
exports.isFreeBSD = process.platform === 'freebsd';
1722

1823
function rimrafSync(p) {
1924
try {
Collapse file

‎test/parallel/test-tick-processor.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tick-processor.js
+5-3Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ runTest(/LazyCompile.*\[eval\]:1|.*% UNKNOWN/,
2020
};
2121
setTimeout(function() { process.exit(0); }, 2000);
2222
f();`);
23-
if (process.platform === 'win32' ||
24-
process.platform === 'sunos' ||
25-
process.platform === 'freebsd') {
23+
if (common.isWindows ||
24+
common.isSunOS ||
25+
common.isAix ||
26+
common.isLinuxPPCBE ||
27+
common.isFreeBSD) {
2628
console.log('1..0 # Skipped: C++ symbols are not mapped for this os.');
2729
return;
2830
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.