Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0895576

Browse filesBrowse files
nofwayyMylesBorins
authored andcommitted
test: correct labelling of asserts errors
PR-URL: #23531 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 90cbeae commit 0895576
Copy full SHA for 0895576

File tree

Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-tls-over-http-tunnel.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-over-http-tunnel.js
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@ const proxy = net.createServer((clientSocket) => {
5757
clientSocket.on('data', (chunk) => {
5858
if (!serverSocket) {
5959
// Verify the CONNECT request
60-
assert.strictEqual(`CONNECT localhost:${server.address().port} ` +
60+
assert.strictEqual(chunk.toString(),
61+
`CONNECT localhost:${server.address().port} ` +
6162
'HTTP/1.1\r\n' +
6263
'Proxy-Connections: keep-alive\r\n' +
6364
`Host: localhost:${proxy.address().port}\r\n` +
64-
'Connection: close\r\n\r\n',
65-
chunk.toString());
65+
'Connection: close\r\n\r\n');
6666

6767
console.log('PROXY: got CONNECT request');
6868
console.log('PROXY: creating a tunnel');
@@ -126,7 +126,7 @@ proxy.listen(0, common.mustCall(() => {
126126
}
127127

128128
function onConnect(res, socket, header) {
129-
assert.strictEqual(200, res.statusCode);
129+
assert.strictEqual(res.statusCode, 200);
130130
console.log('CLIENT: got CONNECT response');
131131

132132
// detach the socket
@@ -149,10 +149,10 @@ proxy.listen(0, common.mustCall(() => {
149149
agent: false,
150150
rejectUnauthorized: false
151151
}, (res) => {
152-
assert.strictEqual(200, res.statusCode);
152+
assert.strictEqual(res.statusCode, 200);
153153

154154
res.on('data', common.mustCall((chunk) => {
155-
assert.strictEqual('hello world\n', chunk.toString());
155+
assert.strictEqual(chunk.toString(), 'hello world\n');
156156
console.log('CLIENT: got HTTPS response');
157157
gotRequest = true;
158158
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.